[nodejs] Handle Next.js weblog shutdown telemetry#6814
Draft
Conversation
Contributor
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 220851921c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
smola
force-pushed
the
smola/nextjs-sigterm
branch
from
2208519 to
cd72628
Compare
5 tasks
smola
force-pushed
the
smola/nextjs-sigterm
branch
from
cd72628 to
dae1137
Compare
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 6bd6d14 | Docs | Datadog PR Page | Give us feedback! |
smola
force-pushed
the
smola/nextjs-sigterm
branch
from
dae1137 to
5546e7b
Compare
smola
force-pushed
the
smola/nextjs-sigterm
branch
from
5546e7b to
6bd6d14
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While fixing SIGTERM dispatch to weblogs (see #6804) I noticed the Next.js weblog does not exit gracefully on SIGTERM. Its signal handler calls
process.exit, which does not run any beforeExit hook in dd-trace-js.Changes
execto run nextjs, so that signals to the container on docker stop are properly dispatched to the Node app.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present